Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Create Environment workflow issues #2988

Merged
merged 4 commits into from
Feb 16, 2025
Merged

Fix Create Environment workflow issues #2988

merged 4 commits into from
Feb 16, 2025

Conversation

gurevichdmitry
Copy link
Collaborator

@gurevichdmitry gurevichdmitry commented Feb 4, 2025 •
edited
Loading

Summary of your changes

This PR fixes issues related to the Create Environment workflow:

  • The DeploymentFailed error with the code RoleAssignmentUpdateNotPermitted occurs when attempting to update a role assignment that is not allowed. Since we regularly create and delete roles, sometimes we use the same deployment name, which prevents creation or updates. To fix this, I added deployment_name randomization.
  • Fixed an issue in Terraform that prevented separate modules from being installed.

Screenshot/Data

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@mergify Mergify
Copy link

mergify bot commented Feb 4, 2025

This pull request does not have a backport label. Could you fix it @gurevichdmitry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-v8.x label Feb 4, 2025
@gurevichdmitry gurevichdmitry added this to the 9.0 milestone Feb 10, 2025
@gurevichdmitry gurevichdmitry marked this pull request as ready for review February 13, 2025 07:28
@gurevichdmitry gurevichdmitry requested a review from a team as a code owner February 13, 2025 07:29
kubasobon
kubasobon approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@kubasobon kubasobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@gurevichdmitry gurevichdmitry merged commit d1b543c into main Feb 16, 2025
9 checks passed
@gurevichdmitry gurevichdmitry deleted the dg-fix-test-env-wf branch February 16, 2025 09:08
mergify bot pushed a commit that referenced this pull request Feb 16, 2025
@gurevichdmitry @mergify
Fix Create Environment workflow issues (#2988)
4d42d92 
* update action logic [skip actions]

* update action

(cherry picked from commit d1b543c)
@mergify mergify bot mentioned this pull request Feb 16, 2025
Merged
5 tasks
gurevichdmitry added a commit that referenced this pull request Feb 16, 2025
@mergify @gurevichdmitry
[8.x](backport #2988) Fix Create Environment workflow issues (#3022)
aef1b82 
* Fix Create Environment workflow issues (#2988)

* update action logic [skip actions]

* update action

(cherry picked from commit d1b543c)

* retrigger ci

---------

Co-authored-by: Dmitry Gurevich <[email protected]>
Co-authored-by: Dmitry Gurevich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubasobon kubasobon kubasobon approved these changes

Assignees

@gurevichdmitry gurevichdmitry

Labels
backport-v8.x
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gurevichdmitry @kubasobon